Add sensor freshness checks

This commit is contained in:
buzera committed 2026-10-26 18:13:00 +02:00
1 parent c434f3995d
commit cea79b6b48
12 files changed
+213 -25

No files matched your search

+40 -1
View File
@@ -83,7 +83,7 @@ class BoundaryTests(unittest.IsolatedAsyncioTestCase):
def set_state(self, entity, value, **attrs):
self.states[entity] = types.SimpleNamespace(state=value, attributes=attrs,
last_changed=self.now - timedelta(hours=1))
last_changed=self.now - timedelta(hours=1), last_reported=self.now)
async def sample(self, seconds=300):
with patch.object(coordinator, 'datetime') as clock:
@@ -271,3 +271,42 @@ class BoundaryTests(unittest.IsolatedAsyncioTestCase):
data = await self.sample()
self.assertEqual(data['status'], 'inputs_changed')
self.assertIsNone(data['proposal'])
async def test_stale_room_pauses_and_recovery_skips_gap(self):
await self.sample()
self.states['sensor.room'].last_reported = self.now - timedelta(minutes=31)
data = await self.sample()
self.assertEqual(data['status'], 'waiting_for_sensors')
self.assertEqual(data['input_quality']['rooms']['sensor.room']['status'], 'stale')
self.assertIsNone(data['proposal'])
self.set_state('sensor.room', '20', unit_of_measurement='°C')
data = await self.sample()
self.assertEqual(data['samples'], 0)
self.assertEqual(data['status'], 'learning')
async def test_stale_weather_fallback_and_optional_outage(self):
self.c.config['outside_temperature_sources'].append('sensor.alternate')
self.set_state('sensor.alternate', '7', unit_of_measurement='°C')
self.states['sensor.outside'].last_reported = self.now - timedelta(minutes=121)
self.c.config['outside_wind_sources'] = ['sensor.missing']
data = await self.sample()
self.assertEqual(data['outside_temperature'], 7)
self.assertEqual(data['status'], 'learning')
quality = data['input_quality']['weather']
self.assertEqual(quality['temperature']['sensor.outside']['status'], 'stale')
self.assertEqual(quality['wind']['sensor.missing']['status'], 'missing')
async def test_fresh_unchanged_reading_is_valid(self):
self.states['sensor.room'].last_changed = self.now - timedelta(days=2)
self.assertEqual((await self.sample())['status'], 'learning')
async def test_configured_age_limit_applied(self):
self.c.config['room_max_age_minutes'] = 5
self.states['sensor.room'].last_reported = self.now - timedelta(minutes=6)
self.assertEqual((await self.sample())['status'], 'waiting_for_sensors')
async def test_invalid_unit_diagnosed_by_metric(self):
self.states['sensor.outside'].attributes['unit_of_measurement'] = 'km/h'
data = await self.sample()
self.assertEqual(data['input_quality']['weather']['temperature']['sensor.outside']['status'],
'invalid_value_or_unit')
+40
View File
@@ -0,0 +1,40 @@
"""Timestamp boundaries and UI translation coverage without HA dependencies."""
import importlib.util
import json
import unittest
from datetime import datetime, timedelta, timezone
from pathlib import Path
ROOT = Path(__file__).resolve().parents[1] / 'custom_components' / 'heating_mpc'
spec = importlib.util.spec_from_file_location('quality', ROOT / 'data_quality.py')
quality = importlib.util.module_from_spec(spec)
spec.loader.exec_module(quality)
class FreshnessTests(unittest.TestCase):
def test_age_boundaries(self):
now = datetime(2026, 10, 26, tzinfo=timezone.utc)
for seconds, expected in ((0, 'valid'), (1800, 'valid'), (1801, 'stale'), (-1, 'future_timestamp')):
with self.subTest(seconds=seconds):
result = quality.freshness(now - timedelta(seconds=seconds), now, 1800)
self.assertEqual(result['status'], expected)
self.assertEqual(result['age_seconds'], seconds)
def test_missing_naive_and_malformed_times(self):
now = datetime.now(timezone.utc)
for timestamp in (None, 'bad', datetime.now()):
self.assertEqual(quality.freshness(timestamp, now, 1800)['status'], 'invalid_timestamp')
def test_invalid_limits_rejected(self):
now = datetime.now(timezone.utc)
for limit in (0, -1, float('inf'), float('nan')):
with self.assertRaises(ValueError):
quality.freshness(now, now, limit)
def test_freshness_settings_translated(self):
for name in ('strings.json', 'translations/en.json', 'translations/ro.json'):
data = json.loads((ROOT / name).read_text())
for section, step in (('config', 'user'), ('options', 'init')):
labels = data[section]['step'][step]['data']
for key in ('room_max_age_minutes', 'weather_max_age_minutes'):
self.assertTrue(labels[key])